fix(ci): stabilize qwen3-decode daily CI and bump PTOAS to v0.30 by YunjiQin · Pull Request #1101 · hw-native-sys/pypto

YunjiQin · 2026-04-21T02:27:21Z

Summary

Fixes qwen3-decode Daily CI failures (#1098) with three related changes:

Shell compatibility: The container job defaults to sh (dash) which doesn't support bash array syntax (failed=()). Added shell: bash to the "Run qwen3 decode examples" step.
Skip TestMscatter: TestMscatter hangs on a5 due to a simpler runtime bug when executing SIMT kernels (simpler#649). Excluded from a5 daily CI until the upstream fix lands.
PTOAS v0.30 + qwen3 sync fix: Bumped PTOAS_VERSION from v0.25 to v0.30 (with updated SHA256), pinned pto-isa to commit d5bcc23, updated qwen3 example paths to the new examples/models/qwen3/32b/ layout, set PYTHONPATH for the decode step, and cleaned the ./runtime/build directory before reinstalling simpler to avoid stale builds.

Test plan

Trigger workflow_dispatch on Daily CI after merge to verify qwen3-decode passes
Alternatively, wait for next scheduled run at UTC 22:00

gemini-code-assist · 2026-04-21T02:27:26Z

Note

Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported.

coderabbitai · 2026-04-21T02:27:36Z

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

@coderabbitai resume to resume automatic reviews.
@coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

▶️ Resume reviews
🔍 Trigger review

📝 Walkthrough

Walkthrough

Removed the repository's main CI workflow file and updated the Daily CI workflow to run on push/pull_request to main (keeps workflow_dispatch), set an explicit bash shell for a qwen3-decode step, and exclude TestMscatter from A5 system-test filters.

Changes

Cohort / File(s)	Summary
CI Workflow Removal `\.github/workflows/ci\.yml`	Deleted the entire GitHub Actions CI workflow, removing all triggers and jobs (pre-commit, clang-tidy, unit tests on ubuntu/macos, hardware/system tests, A5 simulator tests, and fuzz tests with artifact handling).
Daily CI Trigger & Job Tweaks `\.github/workflows/daily_ci\.yml`	Changed trigger from scheduled cron to `push`/`pull_request` on `main` (keeps `workflow_dispatch`), set `shell: bash` for the qwen3-decode step, and updated A5 system-tests `pytest -k` filter to additionally exclude `TestMscatter`.

Sequence Diagram(s)

(omitted)

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

Possibly related PRs

ci(daily): add a5 system tests job to daily ci #994 — Also modifies .github/workflows/daily_ci.yml (triggers and qwen3-decode behavior).
fix(ci): update daily CI workflow to use qwen3 decode script (#980) #981 — Edits the qwen3 decode step and related workflow configuration in .github/workflows/daily_ci.yml.
feat(ci): add daily CI workflow for qwen3 decode with NPU support #945 — Related changes to Daily CI scheduling and A5/system-test workflow setup.

Suggested reviewers

lyfne123
Hzfengsy

Poem

🐰
Workflows hop from cron to push,
CI lanes cleared in one swift rush,
A bash set firm, a test now skipped,
Old file gone — the logs unclipped,
Hopping onward, carrots and CI plush.

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name	Status	Explanation	Resolution
Title check	⚠️ Warning	The title references 'bump PTOAS to v0.30' but the changes show only workflow trigger/configuration updates and test exclusions—no PTOAS version bump is evident in the diff.	Update the title to accurately reflect the actual changes: the conversion of daily CI from scheduled to push/PR triggers and the exclusion of TestMscatter, such as 'fix(ci): convert daily CI to push/PR triggers and exclude TestMscatter'.
Out of Scope Changes check	❓ Inconclusive	Changes to daily_ci.yml include the bash shell fix for qwen3-decode and TestMscatter exclusion for a5-system-tests, both addressing issue `#1098`; removal of ci.yml is substantial but appears intentional and related to CI restructuring.	Clarify whether the removal of the entire ci.yml workflow was intentional and necessary, as it represents a significant change beyond the qwen3-decode fix described in the PR title and description.

✅ Passed checks (3 passed)

Check name	Status	Explanation
Linked Issues check	✅ Passed	The PR addresses the qwen3-decode job failure from issue `#1098` by adding bash shell specification, and also excludes TestMscatter from a5 system tests as referenced in the objectives.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description check	✅ Passed	The pull request description clearly relates to the changeset, describing fixes for Daily CI failures including shell compatibility, TestMscatter exclusion, and related updates.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In @.github/workflows/daily_ci.yml:
- Around line 3-8: The workflow lost its scheduled trigger so the
notify-on-failure step that guards on github.event_name == 'schedule' will never
run; restore a schedule event by adding a schedule: block with a daily cron
(e.g., a single daily cron entry) to the workflow triggers so push/
pull_request/ workflow_dispatch remain and the condition in the
notify-on-failure check (github.event_name == 'schedule') can be satisfied;
update the workflow triggers section (the top-level on: block) to include
schedule alongside push, pull_request and workflow_dispatch.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: bac7546f-be12-4866-84c7-0bd97d693f7f

📥 Commits

Reviewing files that changed from the base of the PR and between ba02283 and e6b602b.

📒 Files selected for processing (2)

.github/workflows/ci.yml
.github/workflows/daily_ci.yml

💤 Files with no reviewable changes (1)

.github/workflows/ci.yml

The qwen3-decode job runs inside a Docker container where GitHub Actions defaults to sh (dash). The script uses bash-specific array syntax (failed=(), failed+=(), ${#failed[@]}) which is invalid in POSIX sh, causing an immediate "Syntax error: '(' unexpected" failure. Fixes hw-native-sys#1098

TestMscatter hangs on a5 due to a simpler runtime bug when executing SIMT kernels. Exclude it from daily CI until the upstream fix lands. Refs hw-native-sys#1098

github-project-automation Bot added this to pto project Apr 21, 2026

coderabbitai Bot reviewed Apr 21, 2026

View reviewed changes

Comment thread .github/workflows/daily_ci.yml

YunjiQin mentioned this pull request Apr 21, 2026

[Daily CI] Failure #1098

Open

YunjiQin force-pushed the issue-1098-fix-qwen3-decode-ci branch 13 times, most recently from 26310f6 to d25b3ef Compare April 24, 2026 03:47

YunjiQin added 2 commits April 24, 2026 21:21

fix(ci): skip TestMscatter in a5 daily CI (simpler#649)

55b7741

TestMscatter hangs on a5 due to a simpler runtime bug when executing SIMT kernels. Exclude it from daily CI until the upstream fix lands. Refs hw-native-sys#1098

YunjiQin force-pushed the issue-1098-fix-qwen3-decode-ci branch from d25b3ef to 64b6920 Compare April 24, 2026 13:25

update ptoas to 0.30, fix sync error in qwen3

da43a96

YunjiQin force-pushed the issue-1098-fix-qwen3-decode-ci branch from 64b6920 to da43a96 Compare April 24, 2026 13:42

YunjiQin changed the title ~~fix(ci): use bash shell for qwen3-decode container step~~ fix(ci): stabilize qwen3-decode daily CI and bump PTOAS to v0.30 Apr 24, 2026

lyfne123 approved these changes Apr 25, 2026

View reviewed changes

lyfne123 merged commit e89dc93 into hw-native-sys:main Apr 25, 2026
8 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(ci): stabilize qwen3-decode daily CI and bump PTOAS to v0.30#1101

fix(ci): stabilize qwen3-decode daily CI and bump PTOAS to v0.30#1101
lyfne123 merged 3 commits intohw-native-sys:mainfrom
YunjiQin:issue-1098-fix-qwen3-decode-ci

YunjiQin commented Apr 21, 2026 •

edited

Loading

Uh oh!

gemini-code-assist Bot commented Apr 21, 2026

Uh oh!

coderabbitai Bot commented Apr 21, 2026 •

edited

Loading

Reviews paused

Walkthrough

Changes

Sequence Diagram(s)

Estimated code review effort

Possibly related PRs

Suggested reviewers

Poem

❌ Failed checks (1 warning, 1 inconclusive)

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

YunjiQin commented Apr 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test plan

Uh oh!

gemini-code-assist Bot commented Apr 21, 2026

Uh oh!

coderabbitai Bot commented Apr 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviews paused

Walkthrough

Changes

Sequence Diagram(s)

Estimated code review effort

Possibly related PRs

Suggested reviewers

Poem

❌ Failed checks (1 warning, 1 inconclusive)

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

YunjiQin commented Apr 21, 2026 •

edited

Loading

coderabbitai Bot commented Apr 21, 2026 •

edited

Loading